Return REQUEST dispatcher type from FilterInvocation dummy request#19161
Open
singhvishalkr wants to merge 1 commit into
Open
Return REQUEST dispatcher type from FilterInvocation dummy request#19161singhvishalkr wants to merge 1 commit into
singhvishalkr wants to merge 1 commit into
Conversation
WebInvocationPrivilegeEvaluator synthesizes a DummyRequest when checking URL access. DispatcherTypeRequestMatcher matches on getDispatcherType(), which previously hit the unsupported proxy and failed for security filter chains that use dispatcherTypeMatchers (see spring-projectsgh-19131). Signed-off-by: Vishal Kumar Singh <vishal.kr.singh2021@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After moving to Spring Security 7, injecting
WebInvocationPrivilegeEvaluatorblows up when the filter chain usesauthorizeHttpRequests(...).dispatcherTypeMatchers(...).AuthorizationManagerWebInvocationPrivilegeEvaluatorfeeds URL checks throughFilterInvocation's synthetic request. That stub never implementedgetDispatcherType(), soDispatcherTypeRequestMatcherconsulted the unsupported servlet proxy and surfacedUnsupportedOperationExceptionbefore authorization ran.The synthetic path used to behave like a normal request dispatch because the introspector transformer wrapped calls with a dummy dispatcher type. Restoring
DispatcherType.REQUESTonDummyRequestputs synthetic evaluations back in line with that expectation.FilterInvocationTestsnow pins the dispatcher type so this cannot regress quietly.Closes gh-19131