Undo change to SIG has_target_soc and has_reserve_soc
#3124
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit aa180dc altered the config.py values for `has_target_soc` and `has_reserve_soc` to True in `config.py`, referencing issue springfall2008#2077. However, this causes Predbat to set the target SOC to 0% (or some other minimum reserve value) when in Demand and Freeze Charge mode, which forbids the system from charging the battery from solar. Looking at the discussion in springfall2008#2077, it appears that this change was stated as not working correctly by its original proposer, and all responses have concurred that it is not working correctly. Revert the change and set the parameters back to False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit aa180dc altered the config.py values for
has_target_socandhas_reserve_socto True inconfig.py, referencing issue #2077. However, this causes Predbat to set the target SOC to 0% (or some other minimum reserve value) when in Demand and Freeze Charge mode, which forbids the system from charging the battery from solar. Looking at the discussion in #2077, it appears that this change was stated as not working correctly by its original proposer, and all responses have concurred that it is not working correctly.Revert the change and set the parameters back to False.