Remove unset HISTFILE from post install script #25082
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is removing all
unset HISTFILEshell commands: when I update spyder and the post install script runs this triggers a malicious script alerts in crowdstrike (www.crowdstrike.com) and many questions from my security team.Unsetting HISTFILE is not necessary to update sypder, so I am proposing to remove those.
Doc, for bash: https://www.gnu.org/software/bash/manual/bash.html#index-HISTFILE
Issue(s) Resolved
See above.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: remisalmon