Skip to content

Callback for picasso-compose painter function #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardikm9850 wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −4
Open

Callback for picasso-compose painter function #2422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions picasso-compose/src/main/java/com/squareup/picasso3/compose/PicassoPainter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import androidx.compose.ui.graphics.DefaultAlpha
import androidx.compose.ui.graphics.drawscope.DrawScope
import androidx.compose.ui.graphics.painter.Painter
import com.google.accompanist.drawablepainter.DrawablePainter
import com.squareup.picasso3.Callback
import com.squareup.picasso3.DrawableTarget
import com.squareup.picasso3.Picasso
import com.squareup.picasso3.Picasso.LoadedFrom
Expand All @@ -37,15 +38,17 @@ import com.squareup.picasso3.RequestCreator
fun Picasso.rememberPainter(
key: Any? = null,
onError: ((Exception) -> Unit)? = null,
request: (Picasso) -> RequestCreator
callback: Callback? = null,
request: (Picasso) -> RequestCreator,
): Painter {
return remember(key) { PicassoPainter(this, request, onError) }
return remember(key) { PicassoPainter(this, request, onError, callback) }
}

internal class PicassoPainter(
private val picasso: Picasso,
private val request: (Picasso) -> RequestCreator,
private val onError: ((Exception) -> Unit)? = null
private val onError: ((Exception) -> Unit)? = null,
private val callback: Callback? = null
) : Painter(), RememberObserver, DrawableTarget {

private var painter: Painter by mutableStateOf(EmptyPainter)
Expand Down Expand Up @@ -92,10 +95,12 @@ internal class PicassoPainter(
}

override fun onDrawableLoaded(drawable: Drawable, from: LoadedFrom) {
callback?.onSuccess()
setPainter(drawable)
}

override fun onDrawableFailed(e: Exception, errorDrawable: Drawable?) {
callback?.onError(e)
onError?.invoke(e)
errorDrawable?.let(::setPainter)
}
Expand Down
14 changes: 13 additions & 1 deletion picasso-sample/src/main/java/com/example/picasso/SampleComposeActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import android.graphics.Bitmap
import android.graphics.Bitmap.Config
import android.graphics.Canvas
import android.os.Bundle
import android.util.Log
import androidx.compose.foundation.Image
import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
Expand Down Expand Up @@ -51,6 +52,7 @@ import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.IntSize
import androidx.compose.ui.unit.dp
import com.squareup.picasso3.Callback
import com.squareup.picasso3.Picasso
import com.squareup.picasso3.Picasso.LoadedFrom.MEMORY
import com.squareup.picasso3.Request
Expand Down Expand Up @@ -115,7 +117,17 @@ fun ImageGrid(
items(urls.size) {
val url = urls[it]
Image(
painter = picasso.rememberPainter(key = url) {
painter = picasso.rememberPainter(key = url, callback = object : Callback {
override fun onSuccess() {
// Image was loaded successfully
}

override fun onError(t: Throwable) {
// Unable to Load Image
Log.e(this.javaClass.name,t.message,t)
}

}) {
it.load(url).placeholder(R.drawable.placeholder).error(R.drawable.error)
},
contentDescription = null,
Expand Down