Fail early if missing Internet Permission#554
Merged
dnkoutso merged 1 commit intoJul 8, 2014
Conversation
Collaborator
There was a problem hiding this comment.
I think this is a bit too early. We support loading from many places other than the internet.
Contributor
Author
There was a problem hiding this comment.
Forgot about those. How about in NetworkBitmapHunter's constructors?
Collaborator
There was a problem hiding this comment.
That seems reasonable to me so long at the exception makes it back to the main thread.
dnkoutso
added a commit
that referenced
this pull request
Jul 8, 2014
…ssion Fail early if missing Internet Permission
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.