Skip to content

Remove bitmap hunter warnings and unneccesary checks#720

Merged
JakeWharton merged 1 commit into
masterfrom
dimitris/minor-cleanup
Oct 24, 2014
Merged

Remove bitmap hunter warnings and unneccesary checks#720
JakeWharton merged 1 commit into
masterfrom
dimitris/minor-cleanup

Conversation

@dnkoutso
Copy link
Copy Markdown
Collaborator

No description provided.

@dnkoutso dnkoutso added this to the Picasso 2.4 milestone Oct 24, 2014
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action cannot be null here according to IJ.

@JakeWharton
Copy link
Copy Markdown
Collaborator

Failed tests:   getPriorityAfterDetach(com.squareup.picasso.BitmapHunterTest): expected:<[NORMAL]> but was:<[LOW]>

@dnkoutso dnkoutso force-pushed the dimitris/minor-cleanup branch from d832932 to 91381c0 Compare October 24, 2014 19:52
@dnkoutso
Copy link
Copy Markdown
Collaborator Author

/cc @lucasr

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did not take into consideration action which might be there.

@dnkoutso dnkoutso force-pushed the dimitris/minor-cleanup branch from 91381c0 to 06583b1 Compare October 24, 2014 19:54
@JakeWharton
Copy link
Copy Markdown
Collaborator

lgtm

JakeWharton added a commit that referenced this pull request Oct 24, 2014
Remove bitmap hunter warnings and unneccesary checks
@JakeWharton JakeWharton merged commit 2ce8847 into master Oct 24, 2014
@lucasr
Copy link
Copy Markdown
Contributor

lucasr commented Oct 24, 2014

👍

@JakeWharton JakeWharton deleted the dimitris/minor-cleanup branch October 24, 2014 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants