feat(ios): Aggregating toasts when the container's window is nil#6
Draft
johnnewman-square wants to merge 2 commits intomainfrom
Draft
feat(ios): Aggregating toasts when the container's window is nil#6johnnewman-square wants to merge 2 commits intomainfrom
johnnewman-square wants to merge 2 commits intomainfrom
Conversation
Contributor
Author
|
This PR also includes some GitHub action changes to update Xcode and iOS. |
Contributor
Author
|
Moving to draft. There are some downstream KIF failures related to this change. I'll need to iron out a plan to address these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates toast aggregation so that toasts will continue to aggregate when the window is nil. This allows toasts to appear on the UI as long as their presenting controller is a part of a valid
UIViewControllerhierarchy, regardless of whether its view is in the window.This could be used by containers, like tab controllers, that remove unselected children from the view hierarchy while keeping them in the controller hierarchy.
Possible followup - introduce a new ViewEnvironment flag so that we can conditionally enable this behavior?
Checklist