Validate Timestamp values are within spec's range#3550
Open
Validate Timestamp values are within spec's range#3550
Conversation
oldergod
force-pushed
the
bquenaudon.2026-03-18.timestamprange
branch
from
c4c820e to
840d114
Compare
oldergod
force-pushed
the
bquenaudon.2026-03-18.timestamprange
branch
from
840d114 to
ee58484
Compare
oldergod
commented
Mar 18, 2026
| .setOrderedAt( | ||
| Timestamp.newBuilder() | ||
| .setSeconds(-631152000000L) // 1950-01-01T00:00:00.250Z. | ||
| .setSeconds(-631152000L) // 1950-01-01T00:00:00.250Z. |
Member
Author
There was a problem hiding this comment.
we were passing ms... instead of s !
Member
Author
There was a problem hiding this comment.
interestingly, protoc didn't throw though?
JakeWharton
approved these changes
Mar 19, 2026
Collaborator
JakeWharton
left a comment
JakeWharton
left a comment
There was a problem hiding this comment.
I have no real opinion on this. Is the adapter's encode functions the right places to throw, or should it be validated once in the constructor of the message?
Member
Author
|
Hmmm, I was matching protoc behavior but being able to instantiate an invalid object is definitely weird... I'll think a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3548