Adds horizontal scrolling.#142
Open
mhoffmeyerDC wants to merge 1 commit intosroze:masterfrom
mhoffmeyerDC:master
Open
Adds horizontal scrolling.#142mhoffmeyerDC wants to merge 1 commit intosroze:masterfrom mhoffmeyerDC:master
mhoffmeyerDC wants to merge 1 commit intosroze:masterfrom
mhoffmeyerDC:master
Conversation
Collaborator
|
@mhoffmeyerDC please update the tests with this feature. |
graingert
force-pushed
the
master
branch
2 times, most recently
from
21036ac to
79473ca
Compare
|
Greetings! is this work in progress or horizontal infinite scroll will never happen? |
|
Any news on this? @mhoffmeyerDC - did you create the tests for these? @graingert - Would it be difficult to get this into ngInfiniteScroll soon? Even without @mhoffmeyerDC responding? |
|
Would be great to include this feature to release, guys! |
|
Much needed feature, would be great to add this into our next release :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoffeeScript implementation from the discussion in #69.
I followed the existing pattern for binding scope.infiniteScrollHorizontal to scrollHorizontal with $watch. I don't think this is needed since it's not going to change after init. Same for useDocumentBottom. Would either of these need to evaluated after load? Could we save a few listeners with just a simple assignment?