Conversation
Could be considered as pre requirements for sroze#146.
|
+1 |
|
Do you have an example of this functional anywhere that is publicly accessible? |
|
@boushley Facebook chat. edit: Maybe I misunderstood you, you might've meant this specific PR? |
|
Facebook chat is using react js isn't it? I'm not asking for an example of the concept in action. I'm asking for an example of this pull request being used, or a demo of this code. The scroll top stuff appears to only work when |
There was a problem hiding this comment.
If you add containerTopOffset = container.scrollTop(); then this works against the window container as well.
|
Check this http://jsbin.com/xemeletuwi/1/edit?html,js,console,output but this is quite buggy. When I tested it I found out that there is no way to get height before and after prepend items without timeout because my example uses ng-repeat. The solution relies on digest cycle which is slow and you could see that even if you set timeout to small value it shows UI in previous state. |
|
http://jsbin.com/qoqahijene/3/edit |
extended with shouldScrollTop = false
fix for top handler when container not visible
21036ac to
79473ca
Compare
Could be considered as pre requirements for #146
DOESN'T: