[RORDEV-1863] RequestId aware logging #1188
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # es67x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es70x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es710x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es711x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es714x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es716x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es717x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es72x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es73x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es74x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es77x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es78x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es79x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es80x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es810x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es811x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es812x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es813x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es814x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es815x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es816x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es818x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es81x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es82x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es83x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es84x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es85x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es87x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es88x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es89x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es90x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es91x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala # es92x/src/main/scala/tech/beshu/ror/es/services/RestClientAuditSinkService.scala
mgoworko
commented
Nov 30, 2025
| import cats.implicits.* | ||
| import monix.eval.Task | ||
| import org.apache.logging.log4j.scala.Logging | ||
| import tech.beshu.ror.utils.RequestIdAwareLogging |
Collaborator
Author
There was a problem hiding this comment.
Overview of changes:
- everywhere changed
org.apache.logging.log4j.scala.Loggingtotech.beshu.ror.utils.RequestIdAwareLogging loggerrequires implicit instance oftrait HasRequestIdin scope- all implementations of
trait RequestContext,BlockContext,RequestId,ResponseContextextendHasRequestId - in situations, where the request id is not available, the
noRequestIdLoggeris used
That way we known, that all logs either have the request id, or are using easily-searchable noRequestIdLogger
mgoworko
commented
Nov 30, 2025
| rorEsConfig: ReadonlyRestEsConfig) | ||
| (implicit environmentConfig: EnvironmentConfig) | ||
| extends ActionFilter with Logging { | ||
| extends ActionFilter with RequestIdAwareLogging { |
Collaborator
Author
There was a problem hiding this comment.
The changes in modules are 99% the same, with some minor module-specific differences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.