Skip to content

Allow codegens to return a science image to be used for a request #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

ponyisi
Copy link
Contributor

@ponyisi ponyisi commented Feb 26, 2025

GeneratedFileResult now has an additional argument which can be specified to say what image should be used. It is the responsibility of the codegen to figure out how to determine this.

Copy link
Contributor

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me. Thanks for supporting older images as well as newer ones!

@gordonwatts gordonwatts merged commit d5db4be into develop Mar 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants