Skip to content

fix issue59 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue59 #60

wants to merge 2 commits into from

Conversation

@stoneman258
Copy link

@stoneman258 stoneman258 commented Mar 3, 2025 •
edited
Loading

This PR successfully fixed #59 by replacing the API.

Qwaz
Qwaz reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@Qwaz Qwaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you add a test case under tests directory? See the other files under the tests directory and test.py for a reference.

@stoneman258
Copy link
Author

@Qwaz Hi, I have added the test case, could you please check and merge the PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qwaz Qwaz Qwaz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SliceFromRaw False Negative

2 participants

@stoneman258 @Qwaz