Fix testing with coverage #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing with coverage RubyLsp::LspReporter.instance.shutdown will not actually shutdown. It expects to be notified via at_coverage_exit so that it can gather coverage stats.
st0012
reviewed
Jul 19, 2025
Owner
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
Good catch, thanks 👍
BTW I think ruby-lsp can have a PR converting https://github.com/Shopify/ruby-lsp/blob/main/lib/ruby_lsp/test_reporters/lsp_reporter.rb#L59C22-L59C42 into using the start_coverage? helper.
Co-authored-by: Stan Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing with coverage RubyLsp::LspReporter.instance.shutdown will not actually shutdown. It expects to be notified via at_coverage_exit so that it can gather coverage stats.