Skip to content

Fix hardcoded 'stackable' user #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix hardcoded 'stackable' user #1052

merged 2 commits into from
Apr 10, 2025

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Apr 4, 2025

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant

  • Please make sure all these things are done and tick the boxes

  • Add an entry to the CHANGELOG.md file

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@lfrancke lfrancke force-pushed the fix/hardcoded-username branch from 2df06ed to 62cffbd Compare April 4, 2025 17:49
@lfrancke lfrancke self-assigned this Apr 4, 2025
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Apr 4, 2025
@lfrancke lfrancke force-pushed the fix/hardcoded-username branch from 62cffbd to e74bfba Compare April 10, 2025 06:47
@lfrancke lfrancke marked this pull request as ready for review April 10, 2025 06:47
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 10, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review April 10, 2025 07:14
NickLarsenNZ

This comment was marked as resolved.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke added this pull request to the merge queue Apr 10, 2025
@lfrancke lfrancke moved this from Development: In Review to Done in Stackable Engineering Apr 10, 2025
@lfrancke lfrancke moved this from Done to Development: Done in Stackable Engineering Apr 10, 2025
Merged via the queue into main with commit 9819522 Apr 10, 2025
3 checks passed
@lfrancke lfrancke deleted the fix/hardcoded-username branch April 10, 2025 07:16
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants