Skip to content

test(smoke): Test boolean metrics #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jun 2, 2025

Description

Test boolean metrics

Tests stackabletech/docker-images#1140

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber requested a review from a team June 2, 2025 13:21
@siegfriedweber siegfriedweber self-assigned this Jun 2, 2025
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Jun 2, 2025
lfrancke
lfrancke previously approved these changes Jun 2, 2025
@lfrancke
Copy link
Member

lfrancke commented Jun 2, 2025

I assume the docker-images one needs to be merged first but this looks good.

@dervoeti dervoeti self-requested a review June 4, 2025 13:42
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 4, 2025
Copy link
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with and without stackabletech/docker-images#1140, works as expected

@siegfriedweber siegfriedweber added this pull request to the merge queue Jun 4, 2025
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Jun 4, 2025
Merged via the queue into main with commit a4428a9 Jun 4, 2025
17 checks passed
@siegfriedweber siegfriedweber deleted the test/boolean-metrics branch June 4, 2025 15:55
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants