Added comments based on my current understanding of the orchestration code for obtaining keytabs from AD #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
nightkr
reviewed
Jun 4, 2025
| // TGT that is obtained for the operation in the memory of the short lives process | ||
| // spawned by `Command::new` above - this way it'll be wiped from memory once this exits | ||
| // With any shared or persistent ticket cache this might stick around and potentially be | ||
| // reused by later runs |
There was a problem hiding this comment.
Suggested change
| // reused by later runs | |
| // reused by other volumes (which could cause privilege escalations and similar fun issues) |
| // Get a `ChildStdin` object for the spawned process and write the serialized request | ||
| // for a Principal into it in order for the child process to deserialize it and | ||
| // process the request | ||
| let mut stdin = child.stdin.take().context(ChildStdinSnafu)?; |
There was a problem hiding this comment.
The unwrap here is intentional..ish, the stdin pipe is created by spawn() so this should only be None if either:
- We forgot to call
.stdin(Stdio::piped())above - We already called
.stdin.take() - Tokio is børked for some reason
All of those are internal bugs that are probably panic-worthy IMO (though expect would be better than unwrap).
Comment on lines
+105
to
+107
| // This will always return Ok(...) regardless of exit code or output of the child process | ||
| // Failure here means that something went wrong with connecting to the process or obtaining | ||
| // exit code or output |
There was a problem hiding this comment.
Yeah.. we probably want to add a check for .output.status.success()
Comment on lines
+113
to
+116
| // Check for success of the operation by deserializing stdout of the process to a `Response` | ||
| // struct - since `Response` is an empty struct with no fields this effectively means that | ||
| // any output will fail to deserialize and cause an `Error::RunProvisioner` to be propagated | ||
| // with the output of the child process |
There was a problem hiding this comment.
Yeah.. this is also to make sure we have the freedom to return structured values later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I read a small part of the code that is used to generate keytabs from AD and noted down my understanding in comments.
Not sure if correct or helpful to actually merge, but by opening a PR I hope to have a place for discussion.
Definition of Done Checklist
Author