Reduce GraphQL fragments redundancies #2660
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendency, explain and rename identical ITEM_OTS_FIELDS fragments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #2656 we realized that the
COMMENT_FIELDSandCOMMENT_FIELDS_NO_CHILD_COMMENTSfragments were identical.This PR solves some (the most visible) redundancies and inconsistencies across our fragments.
Screenshots
n/a
Additional Context
I changed the name of one of the similarly-named ITEM_OTS_FIELDS fragments, as they serve slightly different purposes. It wasn't necessary but the opportunity was right there.
Also noticed that our
gqlimports are not consistent everywhere, sometimes it's fromgraphql-tagand other times fromapollo/client. Didn't touch them, but it seems thatapollo/client's is the one that we'd want to use (?)Checklist
Are your changes backward compatible? Please answer below:
For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7, QA on every behavior related to the modified fragments.
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
n/a
Did you use AI for this? If so, how much did it assist you?
No, started by searching redundancies and just touched the most apparent ones (comments, streak fields and OTS)