-
Notifications
You must be signed in to change notification settings - Fork 34
Add role for configuring sudoers groups #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Dawud Mehmood <[email protected]>
Why keep it limited to sudoers groups? It could easily support both users and groups. |
No reason to keep it limited, this is just all we needed for the customer site. |
I definitely don't think we should expand if we don't need it. I think current scope/role/PR title is OK TBH. It does definitely need to note in ansible/roles/compute_init/README.md the level of support it provides for running via compute-init. And ideally that needs to not be none. |
- `group`: Required string. The group name to grant sudo privileges to. | ||
- `commands`: Required string. The sudo commands specification (e.g., "ALL=(ALL) ALL"). | ||
- `state`: Optional string. Either "present" (default) or "absent" to remove the configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more indentation to these lines.
My issue with keeping it as it is now: if we want to add users later, we might want to change the way the parameters are defined. It is easier to do now while there are no users of the role. Also, much of what you are doing can be done with https://docs.ansible.com/ansible/latest/collections/community/general/sudoers_module.html. Maybe it could just be a thin wrapper around it? |
We also have support for sudo rules in |
Ok so if we have "native" Ansible support and a single client needing this, I'm strongly in favor of just leaving this as a hook for the moment. We can't wrap every Ansible module in a role. Is there a reason for not leaving it like that? |
No description provided.