Align THV-0038 with horizontal scaling RFC (THV-XXXX)#48
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57088275e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Update the session-scoped client lifecycle RFC to close the gaps
identified during review of the companion horizontal scaling RFC:
- Expand the metadata layer to include per-backend session IDs
(Mcp-Session-Id) and proxyrunner pod URLs, which are required by
THV-XXXX to reconstruct vMCP sessions on a different pod without
re-initializing backend sessions from scratch
- Promote backend session IDs from the runtime layer to the metadata
layer in the dual-layer table, with a rationale note explaining why
they are serializable identifiers and not live connection state
- Replace "horizontal scaling requires sticky sessions" with "sticky
sessions are preferred; Redis-backed storage enables reconstruction
at a one-time cost per re-route"
- Replace the vague "graceful degradation / clients must be recreated"
deployment path with the precise reconstruction steps from THV-XXXX
(Redis lookup → proxyrunner URL → resume existing backend session)
- Update Phase 1 implementation plan to specify that per-backend
metadata is written to SetData() inside MakeSession() after clients
initialize
- Rename non-goal from "Transparent Horizontal Scaling" to
"Sticky-session-free horizontal scaling" and redirect to THV-XXXX
- Add THV-XXXX as a companion RFC in the References section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the session-scoped client lifecycle RFC to close the gaps identified during review of the companion horizontal scaling RFC: