fix(vmcp): /status uses live health monitor state

[yrobla]

Summary

The /status endpoint was reading backend health from the static registry snapshot (set at discovery time and never updated), while /api/backends/health correctly read from the live health monitor. This caused the two endpoints to report inconsistent state for the same backend (issue #4103).

Fix buildStatusResponse() to call GetAllBackendHealthStates() and prefer the monitor's runtime health over the registry's initial value. When health monitoring is disabled the registry value is used as before, preserving backwards compatibility.

Add unit tests that assert /status reflects live monitor state for both healthy and unhealthy transitions, and an e2e It block in the circuit breaker lifecycle suite that compares both endpoints side-by-side once the unstable backend's circuit breaker opens.

Fixes #4103

Type of change

• Bug fix
• New feature
• Refactoring (no behavior change)
• Dependency update
• Documentation
• Other (describe):

Test plan

• Unit tests (task test)
• E2E tests (task test-e2e)
• Linting (task lint-fix)
• Manual testing (describe below)

Changes

File	Change

Does this introduce a user-facing change?

Special notes for reviewers

[Copilot]

Pull request overview

Fixes vMCP /status to report backend health using the live health monitor state (matching /api/backends/health) instead of the static registry snapshot, addressing inconsistent health reporting (Fixes #4103).

Changes:

• Update buildStatusResponse() to prefer health monitor runtime state when available.
• Add unit tests ensuring /status reflects healthy/unhealthy transitions from the monitor and falls back to the registry when monitoring is disabled.
• Add E2E coverage comparing /status and /api/backends/health side-by-side in the circuit breaker lifecycle suite.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
pkg/vmcp/server/status.go	Prefer live monitor health states when building /status output.
pkg/vmcp/server/status_test.go	Add unit tests covering monitor-driven /status behavior and fallback behavior.
test/e2e/thv-operator/virtualmcp/helpers.go	Add HTTP helpers + response structs for /status and /api/backends/health.
test/e2e/thv-operator/virtualmcp/virtualmcp_circuit_breaker_test.go	Add E2E assertion that both endpoints agree on backend health.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e699150f8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.05%. Comparing base (bc31b79) to head (befa1c6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4135      +/-   ##
==========================================
+ Coverage   69.03%   69.05%   +0.01%     
==========================================
  Files         462      462              
  Lines       46485    46494       +9     
==========================================
+ Hits        32093    32105      +12     
+ Misses      11928    11923       -5     
- Partials     2464     2466       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Fixes vMCP /status so it reports backend health from the live health monitor (when enabled), aligning it with /api/backends/health and eliminating inconsistent health reporting (Fixes #4103).

Changes:

• Update buildStatusResponse() to prefer health monitor runtime state over the backend registry’s discovery-time snapshot (with registry fallback when monitoring is disabled).
• Add unit tests covering unhealthy/healthy transitions via the health monitor and verifying registry fallback when monitoring is off.
• Add an e2e circuit-breaker lifecycle assertion that /status and /api/backends/health converge on the same backend health state.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
pkg/vmcp/server/status.go	Switch /status backend health sourcing to live health monitor state (when available).
pkg/vmcp/server/status_test.go	Add helper to start server with health monitoring and tests asserting /status reflects live monitor state + fallback behavior.
test/e2e/thv-operator/virtualmcp/helpers.go	Add typed HTTP helpers and response structs for /status and /api/backends/health in e2e tests.
test/e2e/thv-operator/virtualmcp/virtualmcp_circuit_breaker_test.go	Add e2e check ensuring both endpoints report consistent health for the unstable backend once unhealthy.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Fixes an inconsistency where the vMCP /status endpoint reported backend health from a stale registry snapshot, while /api/backends/health used the live health monitor state (Fixes #4103).

Changes:

• Update /status response building to prefer live health monitor states when monitoring is enabled, falling back to the registry value when disabled.
• Add unit tests covering healthy/unhealthy transitions as reflected by /status when driven by the health monitor.
• Add E2E coverage (plus HTTP helpers) to assert /status and /api/backends/health converge on consistent backend health.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pkg/vmcp/server/status.go	Use live health monitor state (when enabled) to populate backend health in /status.
pkg/vmcp/server/status_test.go	Add unit tests validating /status tracks health monitor state and preserves the no-monitor fallback.
test/e2e/thv-operator/virtualmcp/helpers.go	Add typed HTTP helpers to query/decode /status and /api/backends/health responses for E2E assertions.
test/e2e/thv-operator/virtualmcp/virtualmcp_circuit_breaker_test.go	Add E2E test ensuring /status and /api/backends/health report consistent backend health once the circuit opens.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.