Add notifications/elicitation/complete to MCP parser#4157
Merged
Conversation
The MCP 2025-11-25 spec defines notifications/elicitation/complete as a server-to-client notification sent when an out-of-band URL-mode elicitation completes. This was the only spec method not yet handled by the parser. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JAORMX
requested review from
ChrisJBurns,
amirejaz,
blkt,
jhrozek and
yrobla
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4157 +/- ##
==========================================
- Coverage 68.88% 68.86% -0.03%
==========================================
Files 461 464 +3
Lines 46562 46729 +167
==========================================
+ Hits 32075 32179 +104
- Misses 11987 11997 +10
- Partials 2500 2553 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhrozek
approved these changes
Mar 16, 2026
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
LGTM — spec-compliant, well-tested, completes coverage of all 31 MCP 2025-11-25 methods.
While reviewing, noticed a pre-existing issue: progress/update in the methodHandlers map is not a valid MCP spec method (only notifications/progress is). Filed #4170 to track cleanup.
aron-muon
pushed a commit
to aron-muon/toolhive
that referenced
this pull request
Mar 16, 2026
The MCP 2025-11-25 spec defines notifications/elicitation/complete as a server-to-client notification sent when an out-of-band URL-mode elicitation completes. This was the only spec method not yet handled by the parser. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifications/elicitation/completeas a server-to-client notification sent when an out-of-band URL-mode elicitation completes. This was the only spec-defined method not yet handled by the parser (30 of 31 covered).elicitationIdas the resource identifier, plus tests for the middleware round-trip and extraction logic.Type of change
Test plan
task test)task lint-fix)Generated with Claude Code