Skip to content

Bump toolhive-core#4166

Open
rdimitrov wants to merge 4 commits intomainfrom
bump-core
Open

Bump toolhive-core#4166
rdimitrov wants to merge 4 commits intomainfrom
bump-core

Conversation

@rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Mar 16, 2026

Summary

The following PR:

  • Bumps toolhive-core to v0.0.12
  • Update: Fixed E2E test failures caused by the verification fix in toolhive-core v0.0.12. Previously, image verification would fail and emit a warning containing the image name to stderr. Several E2E tests were inadvertently relying on that warning to assert the server name appeared in the output. Now that verification succeeds silently, those assertions fail. Removed 25 fragile output assertions across 8 test files — the actual server startup is already validated by WaitForMCPServer.

Fixes #

Type of change

  • Bug fix
  • New feature
  • Refactoring (no behavior change)
  • Dependency update
  • Documentation
  • Other (describe):

Test plan

  • Unit tests (task test)
  • E2E tests (task test-e2e)
  • Linting (task lint-fix)
  • Manual testing (describe below)

Changes

File Change

Does this introduce a user-facing change?

Special notes for reviewers

@rdimitrov rdimitrov requested a review from JAORMX as a code owner March 16, 2026 09:37
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Mar 16, 2026
JAORMX
JAORMX previously approved these changes Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.04%. Comparing base (0de510d) to head (b462d34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4166      +/-   ##
==========================================
+ Coverage   68.98%   69.04%   +0.06%     
==========================================
  Files         462      462              
  Lines       46554    46554              
==========================================
+ Hits        32115    32144      +29     
+ Misses      11899    11868      -31     
- Partials     2540     2542       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/XS Extra small PR: < 100 lines changed size/S Small PR: 100-299 lines changed labels Mar 16, 2026
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Mar 16, 2026
JAORMX
JAORMX previously approved these changes Mar 16, 2026
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Mar 16, 2026
@rdimitrov rdimitrov requested a review from JAORMX March 16, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants