-
Notifications
You must be signed in to change notification settings - Fork 1
Add workflow which restarts failed konflux -on-push checks #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add workflow which restarts failed konflux -on-push checks #246
Conversation
msugakov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI-assisted?
Yes, but I had to tune it because the full AI implementation was wrong even though prompt was quite precise |
|
Sorry to put it in the face like this, but: https://github.com/msugakov/msugakov/blob/main/No_I_will_not_review_your_LLM_generated_code.md The problem I have with this change as it is, I would not write it this way. I'm almost sure you wouldn't either. There are more subtle questions I could ask but I'll hold them for later assuming the change still needs to be edited and validated. Speaking of which, if you can't run the workflow due to |
|
Generally, I like the idea and it's similar to https://github.com/stackrox/stackrox/blob/master/.github/workflows/retest_periodic.yml (maybe you can see how things were done differently there).
In general, no new workflow can be triggered from a PR as a security measure from GH.
I don't know if you can steer the workflow behaviour from different branches, but in any case, a workflow under this name needs to be present in the default branch of the repo. If you want to test this workflow, I would suggest to create a public repository in your private GitHub org to freely iterate on the workflow. I am open to reviewing LLM-generated content - I would just ask you to provide atomic commits such that AI's and your thinking and testing is documented. :) |
Add a workflow which automatically restarts Konflux failed
-on-pushbuilds up to MAX_RETRIES times for finished CI jobs.There are two caveats:
check_runshould be on the base branch to trigger. So I cannot test it from the PR.check_runevents works for Konflux CI.If it works fine, then I will migrate it to https://github.com/stackrox/actions repo for easy-to-share purpose