[P0] Enabling FSDP with pyvene backbone change #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions:
Ref: stanfordnlp/pyvene#204
The base intervenable class does not support DPP or FSDP. One reason is that the interventions are saved in a python-native dict, rather than a torch-native dict which makes DP wrappers unaware of params of interventions.
This is the first change to implement and validate pyvene backbone is compatible with DPP and FSDP. This change is crucial for the pyreft library to work with larger models, especially when inference-time # token is being scaled.