Fix taxonomy default blueprint where namespace is null#522
Fix taxonomy default blueprint where namespace is null#522SteJW wants to merge 1 commit intostatamic:5.xfrom
Conversation
|
Thanks for the PR, but this changes the default behaviour to be namespaces driven by eloquent by default, when we want the opposite when namespaces != 'all' - it should make files the default. |
|
In my config I have the following: The change keeps checking the namespaces, but it doesnt return false when a namespace is null. On line 28 of the BlueprintRepository, it will use the model when it's null |
|
The point of it returning false was for it to defer to the file repository: eloquent-driver/src/Fields/BlueprintRepository.php Lines 24 to 26 in 712568d |
|
Doesn't it still do that with blueprints that are not in the config, hence not in the database? This should only skips null namespaces, and look for them in the database. Would there be a way to have the null namespace look for the file repository? |
|
Thats how it currently works, it looks in the file repo - thats the behaviour you have changed. |
I reported a bug in the statamic importer, but it's an eloquent related problem. It's also causing the a problem in the overview of taxonomies (/cp/taxonomies) with the same error.
I created a pull request for a small fix.