Initial switch from using jar to using zip #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way users don't need to install java to run us. Jar is just a zip file so the change is purely cosmetic. The ocaml side may be more of a rabbit hole, which then may extend to the other analyzers. There are still some things using the .jar extension: - `bchsummaries.jar` since that file is a copy of what we have in the ocaml analyzer repo: https://github.com/static-analysis-engineering/codehawk/tree/master/CodeHawk/CHB/bchsummaries https://github.com/static-analysis-engineering/codehawk/blob/master/CodeHawk/CHB/bchsummaries/makejar.sh - `*functions.jar` in the analysis folder: the ocaml analyzer reads in this file and expects that filename: https://github.com/static-analysis-engineering/codehawk/blob/master/CodeHawk/CHB/bchlib/bCHPreFileIO.ml#L183-L191
sipma
approved these changes
Sep 16, 2025
Contributor
sipma
left a comment
sipma
left a comment
There was a problem hiding this comment.
Thank you! This is a very good thing, to get rid of the java dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way users don't need to install java to run us. Jar is just a zip file so the change is purely cosmetic:
zipby default creates archives so no need for any command line optionszipdoesn't have an equivalent option tojar -Cso instead we tellsubprocessto run the zip command from the folder we were passing to
jar -C.The ocaml side may be more of a rabbit hole, which then may extend to the other analyzers.
There are still some things using the .jar extension:
bchsummaries.jarsince that file is a copy of what we have in the ocaml analyzer repo:https://github.com/static-analysis-engineering/codehawk/tree/master/CodeHawk/CHB/bchsummaries https://github.com/static-analysis-engineering/codehawk/blob/master/CodeHawk/CHB/bchsummaries/makejar.sh
*functions.jarin the analysis folder: the ocaml analyzer reads in this file and expects that filename: https://github.com/static-analysis-engineering/codehawk/blob/master/CodeHawk/CHB/bchlib/bCHPreFileIO.ml#L183-L191