-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize workflows. Remove 'ssb-bip' profile #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 9 files at r1, all commit messages.
Reviewable status: 6 of 9 files reviewed, 3 unresolved discussions (waiting on @mallport)
.github/workflows/build-app.yml
line 1 at r1 (raw file):
name: Build
I think this should say "Build Application"
.github/workflows/build-deploy.yml
line 1 at r1 (raw file):
## This workflow is either triggered when:
this comment is a bit confusing
.github/workflows/release.yml
line 109 at r1 (raw file):
GITHUB_TOKEN: ${{ steps.app-token.outputs.token }} with: release_id: ${{ steps.create_github_release.outputs.id }}
we should have an action which publishes a draft release when PRs from the 'release' branch is merged to master
Code quote:
- name: Publish GitHub release
uses: eregon/publish-release@v1
env:
GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
with:
release_id: ${{ steps.create_github_release.outputs.id }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 10 files reviewed, 3 unresolved discussions (waiting on @skykanin)
.github/workflows/build-app.yml
line 1 at r1 (raw file):
Previously, skykanin (Nicholas) wrote…
I think this should say "Build Application"
Done.
.github/workflows/build-deploy.yml
line 1 at r1 (raw file):
Previously, skykanin (Nicholas) wrote…
this comment is a bit confusing
Done.
.github/workflows/release.yml
line 109 at r1 (raw file):
Previously, skykanin (Nicholas) wrote…
we should have an action which publishes a draft release when PRs from the 'release' branch is merged to master
Good suggestion, done
Lots of changes here, heavily inspired from dapla-team-api:
deploy.yml
: Generic workflow for deploying to NAISbuild.yml
: Runs on every pull request and pushes to main. If the commit is in the main branch, builds and pushes to AR and deploys to the NAIS test clusterrelease-docker.yml
: Runs when a new release is published. Builds and pushes the application to AR, and deploys to the NAIS production clusterNew changes in fac5a3a:
Modularize even further, removing the workflow for building and pushing artifacts when releasing and instead sharing that logic.
New changes in 11c4cd9:
Don't publish the release - instead, run
mvn release
on therelease
branch, and open a PR with the changes. The intent is to manually merge this PR and publish the release draft, which kicks the can to the workflows for build/deploymentThis change is