Fix query truncation in WebSocket.connect #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Sep 16, 2025
| if uri.port.len <= 0: | ||
| uri.port = if secure: "443" else: "80" | ||
|
|
||
| let pathQuery = |
There was a problem hiding this comment.
would $uri work here? It should reconstruct the whole uri (including logins etc)
There was a problem hiding this comment.
I don't think so. This string will eventually get passed to HttpClient.request and used in generateHeaders, which only uses the path and query parts of the Uri.
There was a problem hiding this comment.
Actually, I misunderstood the question. It should work, it just would be equivalent to {path}?{query} with the current implementation of all the other stuff. But {path}?{query} is a smaller deviation IMO.
There was a problem hiding this comment.
please rebase and add a test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
WebSocket.connectis called with anUriobject, the query part in completely ignored. Fixing this.