Make nimbus beacon node accessible for threading and as a module. #7299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedromiguelmiranda
force-pushed
the
dev/pedro/pubBN
branch
from
454ead7 to
413c77e
Compare
arnetheduck
reviewed
Jul 18, 2025
| writeFile filename, $os.getCurrentProcessId() | ||
| gPidFile = filename | ||
| addExitProc proc {.noconv.} = discard io2.removeFile(gPidFile) | ||
| if shouldCreatePidFile.load(): |
There was a problem hiding this comment.
shouldn't this compareandswap(true)? this way, the variable doesn't have to be public and it's guaranteed to run once only
also, this should be moved to nimbus_binary_common if it's going to be shared between binaries
There was a problem hiding this comment.
needs to be public, otherwise a different thread can not read/write.
The purpose of this change is to avoid the the error triggered by addExitProc on a threaded environment, when it tries to delete something that does not exist anymore.
Agree on moving this to nimbus_binary_common
pedromiguelmiranda
force-pushed
the
dev/pedro/pubBN
branch
from
8949878 to
24ec457
Compare
added 2 commits
July 23, 2025 13:51
- Add a public entry point to nimbus beacon. - protect database file lock concurrent creation/deletion
pedromiguelmiranda
force-pushed
the
dev/pedro/pubBN
branch
from
24ec457 to
857a1e4
Compare
etan-status
force-pushed
the
unstable
branch
3 times, most recently
from
a0510ce to
aa88cd4
Compare
siddarthkay
force-pushed
the
unstable
branch
from
6c84d01 to
b118196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a public entry point to nimbus beacon node by changing 'handleStartUpCmd'
scope to public.
protect database file lock concurrent creation/deletion