Create execution payload gossip validation #7623
Conversation
| # check the DAG chain | ||
| pool.dag.getBlockRef(blockRoot).isSome() | ||
|
|
||
| func isBlockSeen*( |
There was a problem hiding this comment.
Is this overload used anywhere except the tests, or would it be?
There was a problem hiding this comment.
You're right. It can be removed.
| # any side effects until the message is fully validated, or invalid messages | ||
| # could be used to push out valid messages. | ||
|
|
||
| proc processExecutionPayloadGloas( |
There was a problem hiding this comment.
Maybe processExecutionPayloadEnvelope instead of processExecutionPayloadGloas; it more usefully/accurately describes what it's doing. There will be other forks after Gloas, for which this function will still apply.
There was a problem hiding this comment.
Yup sure that works for me. I was thinking it would be a temporary function for processing the execution payload from either beacon_block or execution_payload.
| pool.checkEnvelopeProgress(envelope.toExecPayloadUniqKey(), | ||
| ExecPayloadEnvelopeProgress.Processed) | ||
|
|
||
| func isBlockExecutionEnabled*( |
There was a problem hiding this comment.
Is this used anywhere, or would it be?
There was a problem hiding this comment.
Yes, as execution payload is being removed from block, it would be used in the beacon_block to determine the route of validation.
|
|
||
| blocks: Table[Eth2Digest, BeaconBlockDetail] | ||
| ## Blocks that received from the network. | ||
| envelopes: OrderedTable[ExecPayloadUniqKey, ExecPayloadEnvelopeDetail] |
There was a problem hiding this comment.
Why is this an OrderedTable?
There was a problem hiding this comment.
It would be used for pruning old data. Or should I use Table for now and modify it when implementing date pruning?
ahshum
changed the title
2 participants
processExecutionPayloadGloasis a synced func to enable processing of full beacon block. I think it would be refactored to the block processor (or something similar) to be processed in a queue and save into the db if that's necessary.