Add execution payload bid pool #7646
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
Oct 23, 2025
beacon_chain/nimbus_beacon_node.nim
Outdated
| MsgSource.gossip, signedBlock))) | ||
|
|
||
| # execution_payload_bid | ||
| # https://github.com/ethereum/consensus-specs/blob/v1.6.0-beta.0/specs/gloas/p2p-interface.md#execution_payload_bid |
tersec
reviewed
Oct 23, 2025
tersec
reviewed
Oct 24, 2025
|
|
||
| try: | ||
| for key, detail in pool.bids: | ||
| if detail.bid.message.slot < finalizedSlot: |
There was a problem hiding this comment.
How much of a concern is a whole-pool iteration, as this pruning code does? It's conceptually inefficient, but whether it's enough to be problematic.
There was a problem hiding this comment.
Very true.
I don't have a figure/data on what the pool size for the bids will potentially look like and the O(n) iteration could very well be bad.
We could potentilaly prune by slots O(slots) instead of bids O(bids)
There was a problem hiding this comment.
The performance gain from pruning by slots was negligible for large pools. The new approach stores only the highest-value bid per slot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement execution payload bid pool for Gloas