Skip to content

Conversation

@vkjr
Copy link
Contributor

@vkjr vkjr commented Nov 4, 2025

Description

ERC20 token symbols and decimals were not displaying correctly in the activity list when token metadata was fetched asynchronously after the initial activity load. The UI was showing wrong values (because of not fetched decimals) and no token name.

Fix:

  • Token symbol and decimals are done using tokenService instead of cached (and possibly incorrect) data
  • refresh UI when new token metadata becomes available

related status-go PR

@vkjr vkjr self-assigned this Nov 4, 2025
@vkjr vkjr requested review from a team as code owners November 4, 2025 15:20
@vkjr vkjr requested review from alaibe and friofry and removed request for a team November 4, 2025 15:20
@status-im-auto
Copy link
Member

status-im-auto commented Nov 4, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
69f0aa9 #1 2025-11-04 15:29:02 ~8 min ios/aarch64 📄log
✔️ 69f0aa9 #1 2025-11-04 15:29:11 ~8 min tests/nim 📄log
69f0aa9 #1 2025-11-04 15:32:12 ~11 min macos/aarch64-nwaku 📄log
69f0aa9 #1 2025-11-04 15:33:12 ~12 min linux/x86_64-nwaku 📄log
✔️ 69f0aa9 #1 2025-11-04 15:35:01 ~13 min tests/ui 📄log
✔️ 69f0aa9 #1 2025-11-04 15:38:02 ~17 min linux/x86_64 📦tgz
✔️ ad8d355 #2 2025-11-04 15:46:10 ~8 min tests/nim 📄log
✔️ ad8d355 #1 2025-11-04 15:47:11 ~9 min android/arm64 🤖apk 📲
✔️ ad8d355 #2 2025-11-04 15:51:26 ~13 min macos/aarch64 🍎dmg
✔️ ad8d355 #2 2025-11-04 15:52:44 ~14 min tests/ui 📄log
✔️ ad8d355 #2 2025-11-04 15:54:56 ~16 min linux/x86_64 📦tgz
✔️ ad8d355 #2 2025-11-04 15:58:43 ~20 min macos/aarch64-nwaku 🍎dmg
✔️ ad8d355 #2 2025-11-04 16:02:11 ~24 min linux/x86_64-nwaku 📦tgz
✔️ ad8d355 #2 2025-11-04 16:10:30 ~32 min windows/x86_64 💿exe
✔️ ad8d355 pr19211 2025-11-04 16:11:48 ~16 min tests/e2e 📊rpt
✔️ ad8d355 PR19211 2025-11-04 16:25:45 ~15 min tests/e2e-windows 📊rpt

@vkjr vkjr force-pushed the fix/display-recently-fetched-erc20-tokens branch from 69f0aa9 to ad8d355 Compare November 4, 2025 15:37
@vkjr vkjr added the blocked label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants