chore_: use sensitive string in MarketDataProxyConfig #6592
+52
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (9)
|
igor-sirotin
requested changes
May 20, 2025
Comment on lines
+76
to
+79
| func (s SensitiveString) ContainedIn(str any) bool { | ||
| return strings.Contains(getValue(str), s.value) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is exactly why I was against adding TrimRight method. We will automatically start adding a ton of other methods, which are implemented in strings and other standard libraries.
It is absolutely fine to use strings.Contains("text", secret.Reveal()).
Think of single responsibility. SensitiveString should not implement each and every method for all use cases. It should remain as slim as possible, providing just 1 feature: keep strings secret until explicitly revealed.
There was a problem hiding this comment.
Same about Equal method.
And especially if they're only used in tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pls review by commit :)