Skip to content

Conversation

@igor-sirotin
Copy link
Collaborator

Improve logging in inputConnectionStringForBootstrapping

Caution

I am logging configJSON here. It's probably not a good idea, as it contain local paths.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Thank you for opening this pull request!

We require pull request titles and commits to follow the Conventional Commits specification and it looks like your PR needs to be adjusted.

Details:

No release type found in pull request title "сhore: pairing logs". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@status-im-auto
Copy link
Member

status-im-auto commented Oct 22, 2025

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ b3c6ee3 #1 2025-10-22 11:33:35 ~3 min linux/status-go 📦zip
✔️ b3c6ee3 #1 2025-10-22 11:37:35 ~7 min windows/status-go 📦zip
✔️ b3c6ee3 #1 2025-10-22 11:41:10 ~11 min linux/nwaku 📦zip
✔️ b3c6ee3 #1 2025-10-22 11:41:18 ~11 min tests-rpc 📄log
✔️ b3c6ee3 #1 2025-10-22 11:57:45 ~27 min tests 📄log
✔️ b3c6ee3 #1 2025-10-22 12:26:26 ~56 min macos/status-go 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 95cb7a5 #2 2025-10-22 14:32:52 ~4 min linux/status-go 📦zip
✔️ 95cb7a5 #2 2025-10-22 14:36:50 ~7 min windows/status-go 📦zip
✔️ 95cb7a5 #2 2025-10-22 14:41:09 ~12 min linux/nwaku 📦zip
✔️ 95cb7a5 #2 2025-10-22 14:41:48 ~12 min tests-rpc 📄log
✔️ 95cb7a5 #2 2025-10-22 14:56:37 ~27 min tests 📄log
✔️ 95cb7a5 #2 2025-10-22 16:13:52 ~1 hr 44 min macos/status-go 📦zip
✔️ 098bf6d #3 2025-10-22 17:27:19 ~8 min windows/status-go 📦zip
✔️ 098bf6d #3 2025-10-22 17:37:08 ~18 min linux/status-go 📦zip
✔️ 098bf6d #3 2025-10-22 17:44:31 ~26 min linux/nwaku 📦zip
✔️ 098bf6d #3 2025-10-22 17:46:06 ~27 min tests-rpc 📄log
✔️ 098bf6d #3 2025-10-22 18:02:08 ~43 min tests 📄log
✔️ 098bf6d #3 2025-10-22 19:33:48 ~2 hr 15 min macos/status-go 📦zip

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 21.73913% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.46%. Comparing base (770ce11) to head (098bf6d).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
mobile/status.go 21.73% 18 Missing ⚠️

❌ Your patch status has failed because the patch coverage (21.73%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7020      +/-   ##
===========================================
- Coverage    59.55%   59.46%   -0.09%     
===========================================
  Files          801      801              
  Lines       114386   114407      +21     
===========================================
- Hits         68119    68029      -90     
- Misses       39276    39382     +106     
- Partials      6991     6996       +5     
Flag Coverage Δ
functional 35.41% <21.73%> (-0.13%) ⬇️
unit 55.16% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mobile/status.go 20.65% <21.73%> (+0.05%) ⬆️

... and 32 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants