Skip to content

Conversation

osmaczko
Copy link
Contributor

It is now self-contained, i.e. it has its own persistence, proto, tests.

closes: #7015

@status-im-auto
Copy link
Member

status-im-auto commented Oct 22, 2025

Jenkins Builds

Click to see older builds (11)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cda9607 #1 2025-10-22 11:54:27 ~3 min linux/status-go 📦zip
✔️ cda9607 #1 2025-10-22 11:57:17 ~6 min windows/status-go 📦zip
✔️ cda9607 #1 2025-10-22 12:02:27 ~11 min linux/nwaku 📦zip
✔️ cda9607 #1 2025-10-22 12:06:18 ~15 min tests-rpc 📄log
✔️ cda9607 #1 2025-10-22 12:22:16 ~31 min tests 📄log
✔️ cda9607 #1 2025-10-22 13:04:08 ~1 hr 13 min macos/status-go 📦zip
✔️ cda9607 #2 2025-10-22 18:38:29 ~4 min linux/status-go 📦zip
✔️ cda9607 #2 2025-10-22 18:40:32 ~6 min windows/status-go 📦zip
✔️ cda9607 #2 2025-10-22 18:45:41 ~11 min linux/nwaku 📦zip
✔️ cda9607 #2 2025-10-22 18:47:22 ~12 min tests-rpc 📄log
✔️ cda9607 #2 2025-10-22 19:02:47 ~28 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 354e5d9 #3 2025-10-22 18:42:30 ~3 min linux/status-go 📦zip
✔️ 354e5d9 #3 2025-10-22 18:46:30 ~5 min windows/status-go 📦zip
✔️ 354e5d9 #3 2025-10-22 18:57:04 ~11 min linux/nwaku 📦zip
✔️ 354e5d9 #3 2025-10-22 18:59:13 ~11 min tests-rpc 📄log
✔️ 354e5d9 #3 2025-10-22 19:31:00 ~27 min tests 📄log
✔️ 354e5d9 #3 2025-10-22 20:19:18 ~5 min macos/status-go 📦zip
✔️ 7c1f854 #4 2025-10-23 06:35:37 ~3 min macos/status-go 📦zip
✔️ 7c1f854 #4 2025-10-23 06:35:48 ~3 min linux/status-go 📦zip
✔️ 7c1f854 #4 2025-10-23 06:37:21 ~5 min windows/status-go 📦zip
✔️ 7c1f854 #4 2025-10-23 06:42:53 ~11 min linux/nwaku 📦zip
✔️ 7c1f854 #4 2025-10-23 06:44:04 ~12 min tests-rpc 📄log
✔️ 7c1f854 #4 2025-10-23 07:00:34 ~28 min tests 📄log

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 76.99115% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.56%. Comparing base (09819b6) to head (7c1f854).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
messaging/layers/segmentation/segmenter.go 65.00% 14 Missing ⚠️
messaging/common/message_sender_segmentation.go 75.00% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7021      +/-   ##
===========================================
- Coverage    59.58%   59.56%   -0.03%     
===========================================
  Files          805      806       +1     
  Lines       114504   114523      +19     
===========================================
- Hits         68232    68215      -17     
- Misses       39276    39314      +38     
+ Partials      6996     6994       -2     
Flag Coverage Δ
functional 35.56% <46.90%> (-0.03%) ⬇️
unit 55.22% <76.99%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
messaging/common/message_sender.go 65.50% <100.00%> (-0.11%) ⬇️
messaging/layers/segmentation/message.go 57.14% <100.00%> (ø)
...essaging/layers/segmentation/sqlite_persistence.go 64.55% <100.00%> (ø)
protocol/protobuf/service.go 57.14% <ø> (ø)
messaging/common/message_sender_segmentation.go 75.00% <75.00%> (ø)
messaging/layers/segmentation/segmenter.go 68.92% <65.00%> (ø)

... and 44 files with indirect coverage changes

@osmaczko osmaczko force-pushed the refactor/messaging-persistence-interfaces branch from 6445824 to 18059a8 Compare October 22, 2025 16:03
Base automatically changed from refactor/messaging-persistence-interfaces to develop October 22, 2025 18:34
@osmaczko osmaczko force-pushed the refactor/isolate-segmentation-layer branch from cda9607 to 354e5d9 Compare October 22, 2025 18:34
It is now self-contained, i.e. it has its own persistence, proto, tests.

closes: #7015
@osmaczko osmaczko force-pushed the refactor/isolate-segmentation-layer branch from 354e5d9 to 7c1f854 Compare October 23, 2025 06:31
@osmaczko osmaczko merged commit b7b5077 into develop Oct 23, 2025
21 checks passed
@osmaczko osmaczko deleted the refactor/isolate-segmentation-layer branch October 23, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Isolate Segmentation Layer

4 participants