Rln fixes #84
Open
Rln fixes #84
+74
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
reviewed
Dec 4, 2025
| karma.slash(member.userAddress, rewardRecipient); | ||
| delete members[identityCommitment]; | ||
|
|
||
| emit MemberSlashed(member.index, msg.sender); |
Member
There was a problem hiding this comment.
Can we add a test for this please?
… queue of a different one
0x-r4bbit
reviewed
Dec 5, 2025
| delete members[identityCommitment]; | ||
|
|
||
| emit MemberSlashed(member.index, msg.sender); | ||
| } |
Member
There was a problem hiding this comment.
This is a breaking change. Would you mind updating the commit accordingly with a breaking change section, as per https://www.conventionalcommits.org/en/v1.0.0/#examples
An example can also be found here: #85
0x-r4bbit
reviewed
Dec 5, 2025
| bytes32 hash = keccak256(abi.encodePacked(privateKey, rewardRecipient)); | ||
| uint256 revealStartTime = slashCommitments[account][hash]; | ||
| bytes32 key = _slashCommitmentKey(msg.sender, hash); | ||
| uint256 revealStartTime = slashCommitments[account][key]; |
Member
There was a problem hiding this comment.
Since this is a fix, we should make it a fix commit. ideally it references the issue it closes
0x-r4bbit
reviewed
Dec 5, 2025
| /// @dev Sets the slash reveal window time. | ||
| /// @param _slashRevealWindowTime: new reveal window time in seconds. | ||
| /// @notice The window time must be at least 1 second and no more than 365 days. | ||
| /// @notice The window time must be at least 1 second and no more than 1 day. |
Member
There was a problem hiding this comment.
Can we reference the issue that it will close?
0x-r4bbit
approved these changes
Dec 5, 2025
Member
0x-r4bbit
left a comment
0x-r4bbit
left a comment
There was a problem hiding this comment.
Changes LGTM!
Only thing I'd adjust is that every commit references the issue they fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #83 #81 #80
Checklist