chore: clean-up#13409
Merged
Merged
Conversation
…`blas/ext/base/dfirst-index-equal` Restore the missing period and paragraph break after the summary line in `docs/repl.txt`, and switch the exported top-level declaration from `declare const` to `declare var` to match the convention used by every other package in the `@stdlib/blas/ext/base` namespace.
…-equal`
Add the missing `.ndarray` suffix to the `{{alias}}.ndarray(...)` REPL
signature and pair the `<!-- lint disable maximum-heading-length -->`
before the C ndarray heading with the corresponding `enable` pragma so
the rule is not left disabled for the remainder of the document.
Remove the stray double space before `=>` in the `get` accessor and add the missing space before the closing bracket in `buf[ (2*i) ] = value.hi;` so the new `Uint64ArrayLike` example matches the sibling `Uint64Array` example directly below and the "spaces around array indices" rule in `docs/style-guides/javascript`.
develop (2026-07-09 → 2026-07-10)develop review
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 10, 2026
develop review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-07-09 12:56 PDT (669fa61) and 2026-07-10 02:46 PDT (ae1746f9) — 26 first-parent merges, dominated by the newblas/ext/base/{sfill-equal,sfill-not-equal,dfill-not-equal,dfirst-index-equal,sfirst-index-equal}packages, theUint64Arraytype addition, and themath/base/special/kernel-betaincC port.This pull request fixes six isolated, diff-confirmed defects surfaced by a two-track review (style-guide compliance × bug scan, four independent reviewers) of that window.
blas/ext/base/dfirst-index-equaldeclare const dfirstIndexEqual: Routine;→declare varinblas/ext/base/dfirst-index-equal/docs/types/index.d.ts:106(fromadf21e7) — every other package in@stdlib/blas/ext/base, includingsfirst-index-equal, declares the top-level export withvar; this was the loneconstoutlier in the namespace.lib/node_modules/@stdlib/blas/ext/base/dfirst-index-equal/docs/repl.txt:5: the412de11docs cleanup dropped the trailing period on the top-level summary and merged it into the following paragraph; restored the period and the blank line, matching the.ndarrayvariant below it.blas/ext/base/sfirst-index-equalecdd8f1mis-paired the<!-- lint disable maximum-heading-length -->comment inlib/node_modules/@stdlib/blas/ext/base/sfirst-index-equal/README.md:238— the closing tag was anotherdisable, leaving the rule off for the rest of the file. Changed it toenable..ndarrayhelp-section heading insfirst-index-equalto actually read{{alias}}.ndarray(...)instead of{{alias}}(...), matching thedfirst-index-equalconvention (ecdd8f1,lib/node_modules/@stdlib/blas/ext/base/sfirst-index-equal/docs/repl.txt:60).types=>in theUint64ArrayLikegetaccessor JSDoc example (lib/node_modules/@stdlib/types/index.d.ts:850); brings it in line with the single-space convention used elsewhere in the file. Introduced inec14192.ec14192: fix missing space before closing bracket inUint64ArrayLikeJSDoc example,buf[ (2*i)] = value.hi;→buf[ (2*i) ] = value.hi;, to match thedocs/style-guides/javascriptarray-index spacing rule already followed by the adjacentUint64Arrayexample (lib/node_modules/@stdlib/types/index.d.ts:860).Related Issues
No.
Questions
No.
Other
Review scope. The 26 commits in the window were split for review:
blas/ext/basepackages (sfill-equal,sfill-not-equal,dfill-not-equal,dfirst-index-equal,sfirst-index-equal) — each cross-checked against siblingdfill-equalfor template drift, and cross-checked against each other for copy-paste / precision-swap errors.math/base/special/kernel-betaincC port (6512a7a) — checked line-by-line againstassign.jsfor control-flow / branching / special-case parity.blas/base/dsyrandblas/base/ssyrenum refactors (5c57284,c519b51) — checked for parity against the pre-existingdtrmvmatrix-triangle-resolve-strpattern.typesUint64Arrayaddition (ec14192), 9docs:commits, namespace / TypeScript declaration updates,test:/bench:/chore:/build:fixups — checked for typos, style-guide compliance, and any unintended behavior change in the fix commits themselves.Deliberately excluded. Any concern that required interpretation, a judgment call, or reading files outside the diff to validate was dropped — including a stylistic observation about
STDLIB_CONSTANT_FLOAT32_SMALLEST_NORMALbeing used as the Modified-Lentz "tiny" replacement in a double-precision continued fraction (safe, mirrors the JS reference; only a Boost-idiom preference), and one comment carry-over from the JS source inkernel-betainc/src/main.c:496(faithful port of unmodified upstream text). See the local audit report for the full drop list and rationale.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Opened as a draft by an automated commit-review routine. Findings were surfaced by four independent reviewer agents (two style-compliance, two bug-scan) over the last-24h
developwindow, de-duplicated, and re-verified against the working-tree diff before any edit. Each fix is exactly the mechanical change described in its bullet — no scope expansion, no drive-by cleanup. A maintainer should audit before promoting out of draft.@stdlib-js/reviewers
Generated by Claude Code