Skip to content

chore: clean-up#13409

Merged
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-07-10
Jul 10, 2026
Merged

chore: clean-up#13409
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-07-10

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

Follow-up fixes for commits merged to develop between 2026-07-09 12:56 PDT (669fa61) and 2026-07-10 02:46 PDT (ae1746f9) — 26 first-parent merges, dominated by the new blas/ext/base/{sfill-equal,sfill-not-equal,dfill-not-equal,dfirst-index-equal,sfirst-index-equal} packages, the Uint64Array type addition, and the math/base/special/kernel-betainc C port.

This pull request fixes six isolated, diff-confirmed defects surfaced by a two-track review (style-guide compliance × bug scan, four independent reviewers) of that window.

blas/ext/base/dfirst-index-equal

  • Fix declare const dfirstIndexEqual: Routine;declare var in blas/ext/base/dfirst-index-equal/docs/types/index.d.ts:106 (from adf21e7) — every other package in @stdlib/blas/ext/base, including sfirst-index-equal, declares the top-level export with var; this was the lone const outlier in the namespace.
  • lib/node_modules/@stdlib/blas/ext/base/dfirst-index-equal/docs/repl.txt:5: the 412de11 docs cleanup dropped the trailing period on the top-level summary and merged it into the following paragraph; restored the period and the blank line, matching the .ndarray variant below it.

blas/ext/base/sfirst-index-equal

  • ecdd8f1 mis-paired the <!-- lint disable maximum-heading-length --> comment in lib/node_modules/@stdlib/blas/ext/base/sfirst-index-equal/README.md:238 — the closing tag was another disable, leaving the rule off for the rest of the file. Changed it to enable.
  • Fixed the .ndarray help-section heading in sfirst-index-equal to actually read {{alias}}.ndarray(...) instead of {{alias}}(...), matching the dfirst-index-equal convention (ecdd8f1, lib/node_modules/@stdlib/blas/ext/base/sfirst-index-equal/docs/repl.txt:60).

types

  • Fix double space before => in the Uint64ArrayLike get accessor JSDoc example (lib/node_modules/@stdlib/types/index.d.ts:850); brings it in line with the single-space convention used elsewhere in the file. Introduced in ec14192.
  • ec14192: fix missing space before closing bracket in Uint64ArrayLike JSDoc example, buf[ (2*i)] = value.hi;buf[ (2*i) ] = value.hi;, to match the docs/style-guides/javascript array-index spacing rule already followed by the adjacent Uint64Array example (lib/node_modules/@stdlib/types/index.d.ts:860).

Related Issues

No.

Questions

No.

Other

Review scope. The 26 commits in the window were split for review:

  • New blas/ext/base packages (sfill-equal, sfill-not-equal, dfill-not-equal, dfirst-index-equal, sfirst-index-equal) — each cross-checked against sibling dfill-equal for template drift, and cross-checked against each other for copy-paste / precision-swap errors.
  • math/base/special/kernel-betainc C port (6512a7a) — checked line-by-line against assign.js for control-flow / branching / special-case parity.
  • blas/base/dsyr and blas/base/ssyr enum refactors (5c57284, c519b51) — checked for parity against the pre-existing dtrmv matrix-triangle-resolve-str pattern.
  • types Uint64Array addition (ec14192), 9 docs: commits, namespace / TypeScript declaration updates, test: / bench: / chore: / build: fixups — checked for typos, style-guide compliance, and any unintended behavior change in the fix commits themselves.

Deliberately excluded. Any concern that required interpretation, a judgment call, or reading files outside the diff to validate was dropped — including a stylistic observation about STDLIB_CONSTANT_FLOAT32_SMALLEST_NORMAL being used as the Modified-Lentz "tiny" replacement in a double-precision continued fraction (safe, mirrors the JS reference; only a Boost-idiom preference), and one comment carry-over from the JS source in kernel-betainc/src/main.c:496 (faithful port of unmodified upstream text). See the local audit report for the full drop list and rationale.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

Opened as a draft by an automated commit-review routine. Findings were surfaced by four independent reviewer agents (two style-compliance, two bug-scan) over the last-24h develop window, de-duplicated, and re-verified against the working-tree diff before any edit. Each fix is exactly the mechanical change described in its bullet — no scope expansion, no drive-by cleanup. A maintainer should audit before promoting out of draft.


@stdlib-js/reviewers


Generated by Claude Code

claude added 3 commits July 10, 2026 12:39
…`blas/ext/base/dfirst-index-equal`

Restore the missing period and paragraph break after the summary line in
`docs/repl.txt`, and switch the exported top-level declaration from
`declare const` to `declare var` to match the convention used by every
other package in the `@stdlib/blas/ext/base` namespace.
…-equal`

Add the missing `.ndarray` suffix to the `{{alias}}.ndarray(...)` REPL
signature and pair the `<!-- lint disable maximum-heading-length -->`
before the C ndarray heading with the corresponding `enable` pragma so
the rule is not left disabled for the remainder of the document.
Remove the stray double space before `=>` in the `get` accessor and add
the missing space before the closing bracket in `buf[ (2*i) ] = value.hi;`
so the new `Uint64ArrayLike` example matches the sibling `Uint64Array`
example directly below and the "spaces around array indices" rule in
`docs/style-guides/javascript`.
@Planeshifter Planeshifter changed the title Follow-up fixes for commits merged to develop (2026-07-09 → 2026-07-10) chore: apply follow-up fixes from last-24h develop review Jul 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dfirst-index-equal $\\color{green}372/372$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}372/372$
$\\color{green}+100.00\\%$
blas/ext/base/sfirst-index-equal $\\color{green}372/372$
$\\color{green}+100.00\\%$
$\\color{green}19/19$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}372/372$
$\\color{green}+100.00\\%$
types $\\color{green}107/107$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}0/0$
$\\color{green}+100.00\\%$
$\\color{green}107/107$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review July 10, 2026 19:54
@kgryte kgryte requested a review from a team July 10, 2026 19:54
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 10, 2026
@kgryte kgryte changed the title chore: apply follow-up fixes from last-24h develop review chore: clean-up Jul 10, 2026
@kgryte kgryte merged commit e713916 into develop Jul 10, 2026
32 of 33 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-07-10 branch July 10, 2026 19:54
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants