Skip to content

test: migrate math/base/special/lnf to ULP-based assertions - #15218

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
Devansh-18155:devansh/ulp-lnf-test
Sep 15, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
Devansh-18155:devansh/ulp-lnf-test

Conversation

@Devansh-18155

Copy link
Copy Markdown
Contributor

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates polynomial evaluation tests in math/base/special/lnf (test.polyval_p.js and test.polyval_q.js) from relative tolerance assertions to ULP difference assertions using @stdlib/number/float32/base/assert/is-almost-same-value.
  • Updates the tests to require a minimum ULP bound of 1.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used AI assistance for identifying unmigrated polynomial test files in lnf, and verifying the minimum ULP bound.


@stdlib-js/reviewers

@Devansh-18155
Devansh-18155 requested a review from a team September 14, 2026 11:15
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Sep 14, 2026
@kgryte kgryte added Tests Pull requests specifically adding tests. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Sep 14, 2026
Comment thread lib/node_modules/@stdlib/math/base/special/lnf/test/test.polyval_p.js Outdated

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. review: 2 and removed review: 5 labels Sep 15, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 15, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Sep 15, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte
kgryte merged commit 8e05fb3 into stdlib-js:develop Sep 15, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 2 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants