-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add math/base/special/asechf
#8832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: add math/base/special/asechf
#8832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Hi @kgryte! I have implemented the C version of Implementation uses the formula: asechf(x) = acosh(1/x) Since
This approach maintains accuracy while avoiding dependency on non-existent All tests passing, It follows stdlib conventions. Ready for review! Ref: #649 |
@stdlib/math/base/special/asechfmath/base/special/asechf
math/base/special/asechfmath/base/special/asechf
|
We need |
|
Ref: #5812 |
|
Understood @kgryte. I agree that waiting for acoshf avoids future refactoring. I will keep this PR open and monitor the progress of acoshf. Once that lands, I will update this implementation to use stdlib_base_acoshf directly and ping you for review. |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves a part of #649
Description
This pull request:
@stdlib/math/base/special/asechf.The package computes the hyperbolic arcsecant of a single-precision floating-point number using the relationship:
Since
acoshfdoes not yet have a C implementation, this implementation uses the double-precisionacoshfunction with appropriate float conversions.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used AI to generate the boilerplate code for the benchmark files and to generate the numerical test fixtures (input/output pairs) for
test.c. The core implementation logic and mathematical correctness were manually verified against standard definitions.@stdlib-js/reviewers