feat: add `math/base/special/log10f` #8873

JavaTypedScript · 2025-12-07T15:07:27Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: missing_dependencies
task: lint_c_examples status: missing_dependencies
task: lint_c_benchmarks status: missing_dependencies
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Progresses #649 .

Description

What is the purpose of this pull request?

This pull request:

Adds c-implementation to log10f in @stdlib/math/base/special

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc · 2025-12-07T17:52:17Z

lib/node_modules/@stdlib/math/base/special/log10f/test/test.js

+var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
+var PINF = require( '@stdlib/constants/float32/pinf' );
+var NINF = require( '@stdlib/constants/float32/ninf' );
+var EPS = require( '@stdlib/constants/float32/eps' );


@JavaTypedScript Can you please refactor this to use var ulpdiff = require( '@stdlib/number/float32/base/ulp-difference' ); instead as done here?

@anandkaranubc Thank you for your suggestions, it really worked!

anandkaranubc · 2025-12-07T17:53:48Z

lib/node_modules/@stdlib/math/base/special/log10f/test/test.js

+			t.strictEqual( y, e, 'x: '+x[i]+', y: '+y+', expected: '+e );
+		} else {
+			delta = abs( y - e );
+			tol = 106.0 * EPS * abs( e );


That's a pretty high number. Are you sure this implementation matches the reference implementation you followed?

Yes it was too high and now i have refactored with your suggestion. New to open source, so I missed it.

anandkaranubc · 2025-12-07T17:59:38Z

lib/node_modules/@stdlib/math/base/special/log10f/test/test.native.js

+			t.strictEqual( y, e, 'x: '+x[i]+', y: '+y+', expected: '+e );
+		} else {
+			delta = abs( y - e );
+			tol = 106.0 * EPS * abs( e );


For debugging, since you are following FreeBSD’s C implementation, you can start by comparing your C implementation with the reference one to identify any differences that could cause such a high tolerance value. After that, run this test file to verify your implementation:

NODE_ADDONS_PATTERN="@stdlib/math/base/special/log10f" make install-node-addons make TESTS_FILTER='@stdlib/math/base/special/log10f/test/test.native.js' test

Yes i have refactored this, Thank you for your guidance.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-12-08T13:14:27Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/log10f	$\color{green}268/268$ $color{green}+100.00%$	$\color{green}16/16$ $color{green}+100.00%$	$\color{green}2/2$ $color{green}+100.00%$	$\color{green}268/268$ $color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

anandkaranubc · 2025-12-08T14:07:19Z

lib/node_modules/@stdlib/math/base/special/log10f/test/test.native.js

+var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
+var PINF = require( '@stdlib/constants/float32/pinf' );
+var NINF = require( '@stdlib/constants/float32/ninf' );
+var EPS = require( '@stdlib/constants/float32/eps' );


This is not needed when you use ulpdiff

Hey, thanks for your review, I have changed it.

anandkaranubc · 2025-12-08T14:11:02Z

lib/node_modules/@stdlib/math/base/special/log10f/test/test.native.js

+	for ( i = 0; i < x.length; i++ ) {
+		y = log10f( x[i] );
+		e = float64ToFloat32( expected[ i ] );
+		if ( y === e ) {
+			t.strictEqual( y, e, 'x: '+x[i]+', y: '+y+', expected: '+e );
+		} else {
+			delta = abs( y - e );
+			tol = EPS * abs( e );
+			t.strictEqual( delta <= tol, true, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+e+'. Δ: '+delta+'. Tolerance: '+tol+'.' );
+		}
+	}


This block should be changed to:

for ( i = 0; i < x.length; i++ ) { x[ i ] = f32( x[ i ] ); y = log10f( x[ i ] ); expected[ i ] = f32( expected[ i ] ); t.strictEqual( ulpdiff( y, expected[ i ] ) <= _, true, 'returns expected value' ); }

_ in ulpdiff( y, expected[ i ] ) <= _ will be filled with a number like 1,2,3, etc.

First try with:

for ( i = 0; i < x.length; i++ ) { x[ i ] = f32( x[ i ] ); y = log10f( x[ i ] ); expected[ i ] = f32( expected[ i ] ); t.strictEqual( y, expected[ i ], 'returns expected value' ); }

If this fails, you can use ulpdiff starting with ulpdiff( y, expected[ i ] ) <= 1 and then step up this number.

My guess is, since you are using FreeBSD as the reference implementation, this number won't exceed 1 or 2 (maybe).

Reference: https://github.com/0PrashantYadav0/stdlib/blob/a8785515d4aab7c059e0d1c45e62f656404e5f45/lib/node_modules/%40stdlib/math/base/special/log1pf/test/test.native.js

ok on to it thanks

anandkaranubc · 2025-12-08T14:15:28Z

lib/node_modules/@stdlib/math/base/special/log10f/test/test.native.js

+var NINF = require( '@stdlib/constants/float32/ninf' );
+var EPS = require( '@stdlib/constants/float32/eps' );
+var abs = require( '@stdlib/math/base/special/abs' );
+var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );


Since this variable name is a bit long, you can refactor it to:

var f32 = require( '@stdlib/number/float64/base/to-float32' );

Ya, I have made the changes, please let me know if there are any changes

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

JavaTypedScript · 2025-12-09T17:06:32Z

@anandkaranubc and @kgryte
Are there any changes or additions to be done to this PR?

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 7, 2025

JavaTypedScript added 2 commits December 7, 2025 15:20

anandkaranubc reviewed Dec 7, 2025

View reviewed changes

anandkaranubc changed the title ~~feat: add math/base/special/log10f~~ feat: add math/base/special/log10f Dec 8, 2025

anandkaranubc reviewed Dec 8, 2025

View reviewed changes

JavaTypedScript added 2 commits December 9, 2025 02:33

Uh oh!

feat: add math/base/special/log10f #8873

Are you sure you want to change the base?

feat: add math/base/special/log10f #8873

Conversation

JavaTypedScript commented Dec 7, 2025

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JavaTypedScript commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `math/base/special/log10f` #8873

feat: add `math/base/special/log10f` #8873

stdlib-bot commented Dec 8, 2025 •

edited

Loading

anandkaranubc Dec 8, 2025 •

edited

Loading

anandkaranubc Dec 8, 2025 •

edited

Loading

JavaTypedScript commented Dec 9, 2025 •

edited

Loading