feat: add `math/base/special/truncbf` #8915

Amansingh0807 · 2025-12-09T10:19:03Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: passed
task: lint_c_examples status: passed
task: lint_c_benchmarks status: passed
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves a part of #649

Description

What is the purpose of this pull request?

This pull request:

This PR adds a C implementation for @stdlib/math/base/special/truncbf.

The package computes the value of a single-precision floating-point number rounded toward zero to n digits in an arbitrary base b.

Implementation Details

Function Signature

float stdlib_base_truncbf( const float x, const int32_t n, const int32_t b );

function truncbf( x, n, b )

Algorithm

The implementation uses the following formula:

truncbf(x, n, b) = trunc(x × b^n) / b^n

It leverages the recently added C implementations of powf (for scaling) and truncf (for truncation) to ensure single-precision accuracy.

Examples

- truncbf( 3.14159f, 2, 10 ); // returns 3.14f
- truncbf( 15.75f, 2, 2 );    // returns 15.75f (Binary base)
- truncbf( 255.99f, 1, 16 );  // returns 255.9375f (Hex base)

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Resolves a part of [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

- Add C implementation for truncbf (single-precision floating-point rounding) - Add JavaScript wrapper with native addon support - Add comprehensive tests (21 test cases, all passing) - Add benchmarks for C, native, Julia, and JavaScript - Add TypeScript declarations and documentation - Add examples for both C and JavaScript - Implement using stdlib's own pow/trunc functions (no math.h dependency) - Support rounding to n digits in arbitrary base b - Handle all edge cases (NaN, ±0, ±Infinity, base=0) Closes stdlib-js#649

- Replace pow with powf in JavaScript and C implementations - Replace trunc with truncf in JavaScript and C implementations - Update variable types from double to float in C code - Update manifest.json dependencies to powf and truncf - Ensures proper single-precision floating-point operations throughout

- Add runtime dependencies (powf, truncf, is-nanf, is-infinitef, float64-to-float32) - Add devDependencies for testing (tape, istanbul, tap-min, constants, abs)

- Add detailed parameter specifications with example values (20 per param) - Add domain definitions and random value generators - Add proper schema version (math/[email protected]) - Include base_alias (truncb) and alias (truncbf) fields - Add test configuration (hermitian: false, symmetric: false) - Complete metadata for automated tooling and documentation

- Revert C code to use pow/trunc (powf/truncf headers not available in build) - Use double precision internally, cast final result to float32 - Fix TypeScript doc examples to show actual float32 precision values - Update manifest.json dependencies back to pow/trunc - Add Apache-2.0 license headers to binding.gyp and include.gypi Fixes: - Compilation errors (missing powf.h, truncf.h) - TypeScript lint errors (incorrect expected values) - License header lint errors

…ry-manifest for dependency resolution

…t values for float32 precision, remove duplicate keyword

kgryte · 2025-12-09T11:04:38Z

lib/node_modules/@stdlib/math/base/special/truncbf/src/addon.c

+* limitations under the License.
+*/
+
+#include "stdlib/math/base/special/truncbf.h"


You don't need to manually do argument munging. You can use an existing macro. E.g., https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/math/base/napi/ternary#stdlib_math_base_napi_module_dii_d-fcn-

kgryte · 2025-12-09T11:05:05Z

lib/node_modules/@stdlib/math/base/special/truncbf/src/main.c

+#include "stdlib/math/base/special/pow.h"
+#include "stdlib/math/base/special/trunc.h"


You need to use single-precision packages.

kgryte · 2025-12-09T11:05:51Z

lib/node_modules/@stdlib/math/base/special/truncbf/manifest.json

+      "task": "build",
+      "wasm": false,
+      "src": [
+        "./src/main.c",


You need to study other packages to see what gets counted as source and what doesn't.

Yeah Sure, i will do it.

…le values in package.json

…wf/truncf

stdlib-bot · 2025-12-09T11:49:19Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/truncbf	$\color{red}197/199$ $\color{green}+0.00%$	$\color{red}11/12$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{red}197/199$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

…wf/truncf

…n.c, NAPI macro in addon.c, and proper manifest.json

Amansingh0807 · 2025-12-09T14:55:35Z

@kgryte I have addressed all your feedback:

Macro Usage: Switched addon.c to use the @stdlib/math/base/napi/ternary macro (and updated dependencies in package.json).
Single-Precision: Updated main.c to use single-precision functions (powf, truncf) and headers.
Manifest: Cleaned up the src array in manifest.json to only include main.c.

Additionally, I fixed the benchmarks to use @stdlib/math/base/special/trunc and resolved all linting/build errors. All checks are passing now.

Amansingh0807 added 4 commits December 9, 2025 14:35

fix: add dependencies to truncbf package.json

8df7b42

- Add runtime dependencies (powf, truncf, is-nanf, is-infinitef, float64-to-float32) - Add devDependencies for testing (tape, istanbul, tap-min, constants, abs)

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 9, 2025

Amansingh0807 added 3 commits December 9, 2025 15:59

fix: update binding.gyp, include.gypi, and manifest.json to use libra…

e76960e

…ry-manifest for dependency resolution

fix: resolve all lint errors - remove trailing whitespace, fix doctes…

cee4280

…t values for float32 precision, remove duplicate keyword

kgryte added the Feature Issue or pull request for adding a new feature. label Dec 9, 2025

kgryte reviewed Dec 9, 2025

View reviewed changes

Amansingh0807 added 5 commits December 9, 2025 16:43

fix: remove trailing whitespace from src/main.c and fix integer examp…

f0b6c67

…le values in package.json

fix: restore correct includes in main.c - use pow/trunc instead of po…

c6ca8b2

…wf/truncf

fix: restore correct includes in main.c - use pow/trunc instead of po…

784039b

…wf/truncf

fix: restore correct includes in main.c - use pow/trunc instead of po…

d7c8e6f

…wf/truncf

fix: restore correct includes in main.c - use pow/trunc instead of po…

fc6dae7

…wf/truncf

Amansingh0807 added 11 commits December 9, 2025 17:38

fix: restore correct includes in main.c - use pow/trunc instead of po…

5365aa1

…wf/truncf

fix: restore correct includes in main.c - use pow/trunc instead of po…

1cfe041

…wf/truncf

fix: restore correct includes in main.c - use pow/trunc instead of po…

8dba89f

…wf/truncf

fix: restore correct includes in main.c - use pow/trunc instead of po…

59e7e26

…wf/truncf

fix: add missing devDependencies and sort alphabetically

e2aa63d

fix: add missing devDependencies and sort alphabetically

978ee5c

fix: add missing devDependencies and sort alphabetically

eca9d52

fix: add missing devDependencies and sort alphabetically

43ac720

fix: add proper indentation to license headers

69211a8

fix: add proper indentation to license headers

10dcf99

fix: use stdlib trunc in benchmark, single-precision functions in mai…

290359c

…n.c, NAPI macro in addon.c, and proper manifest.json

Amansingh0807 added 7 commits December 9, 2025 19:28

fix: use stdlib trunc in benchmark, single-precision functions in mai…

049e558

…n.c, NAPI macro in addon.c, and proper manifest.json

fix: add fii_f NAPI dependency to manifest.json

fac1b21

fix: add fii_f NAPI dependency to manifest.json

f09deb1

fix: add fii_f NAPI dependency to manifest.json

b196c75

fix: add fii_f NAPI dependency to manifest.json

0dbff21

fix: add fii_f NAPI dependency to manifest.json

0872aba

fix: add fii_f NAPI dependency to manifest.json

8935b9e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `math/base/special/truncbf` #8915

feat: add `math/base/special/truncbf` #8915

Amansingh0807 commented Dec 9, 2025

Uh oh!

kgryte Dec 9, 2025

Uh oh!

kgryte Dec 9, 2025

Uh oh!

kgryte Dec 9, 2025

Uh oh!

Amansingh0807 Dec 9, 2025

Uh oh!

stdlib-bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

Amansingh0807 commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		#include "stdlib/math/base/special/pow.h"
		#include "stdlib/math/base/special/trunc.h"

Uh oh!

feat: add math/base/special/truncbf #8915

Are you sure you want to change the base?

feat: add math/base/special/truncbf #8915

Conversation

Amansingh0807 commented Dec 9, 2025

Description

Implementation Details

Function Signature

Algorithm

Examples

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

kgryte Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Amansingh0807 Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Amansingh0807 commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `math/base/special/truncbf` #8915

feat: add `math/base/special/truncbf` #8915

stdlib-bot commented Dec 9, 2025 •

edited

Loading