Skip to content

Fix to use spf13/pflag instead of flag #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5ouma wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix to use spf13/pflag instead of flag #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f32f5e4
fix(internal): Use `spf13/pflag` instead of `flag`
5ouma Apr 22, 2026
ddb9a46
test(internal): Add a unit test to check not passed flag
5ouma Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/util/isFlagPassed.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package util

import "flag"
import flag "github.com/spf13/pflag"

func IsFlagPassed(name string) bool {
found := false
Expand Down
23 changes: 22 additions & 1 deletion internal/util/isFlagPassed_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,32 @@ package util_test
import (
"testing"

flag "github.com/spf13/pflag"
"github.com/stefanlogue/meteor/internal/util"
)

func TestIsFlagPassed(t *testing.T) {
original := flag.CommandLine
t.Cleanup(func() {
flag.CommandLine = original
})

tests := []struct {
name string
flagName string
setFlag bool
want bool
}{
{
name: "version flag is not passed",
flagName: "version",
want: false,
},
{
name: "version flag is passed",
flagName: "version",
want: false, // Will be false in test context unless explicitly set
setFlag: true,
want: true,
},
{
name: "non-existent flag",
Expand All @@ -25,6 +38,14 @@ func TestIsFlagPassed(t *testing.T) {
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
flag.CommandLine = flag.NewFlagSet("test", flag.ContinueOnError)
flag.Bool("version", false, "")
if tt.setFlag {
if err := flag.CommandLine.Set(tt.flagName, "true"); err != nil {
t.Fatalf("failed setting flag %q: %v", tt.flagName, err)
}
}

got := util.IsFlagPassed(tt.flagName)
if got != tt.want {
t.Errorf("IsFlagPassed() = %v, want %v", got, tt.want)
Expand Down
Loading