Add tmalloc dependency to core docker file #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTyson
requested review from
anupsdf and
leighmcculloch
and removed request for
Copilot
6 tasks
leighmcculloch
approved these changes
Jan 23, 2026
| apt-get -y install iproute2 procps lsb-release \ | ||
| git build-essential pkg-config autoconf automake libtool \ | ||
| bison flex sed perl libpq-dev parallel \ | ||
| bison flex sed perl libpq-dev parallel libgoogle-perftools-dev \ |
Member
There was a problem hiding this comment.
Is the dependency needed at runtime too or just build time?
If it's needed at runtime too it'll need to go into the dependencies file as well. Just fyi in case you see a failure at runtime. I wouldn't proactively add it there or anywhere else unless you see a failure.
Contributor
Author
There was a problem hiding this comment.
I'm like 90% sure we don't need it at runtime given how we link it to our build, but the core CI test on stellar/stellar-core#5101 should double check this for us anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new core dependency required in stellar/stellar-core#5101