Bump stellar-xdr to 27.0.0 - #29
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates XDR support for protocol 27 and CAP-0071 transactions.
Changes:
- Upgrades
stellar-xdrfrom 26.0.0 to 27.0.0. - Migrates imports from
stellar_xdr::currto crate-root exports. - Adds regression coverage for
AddressV2Soroban credentials.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Updates the XDR dependency. |
Cargo.lock |
Locks updated transitive dependencies. |
src/xdr_verify.rs |
Migrates production XDR references. |
src/utils.rs |
Migrates the Hash import. |
src/report.rs |
Migrates the Hash import. |
src/tests/xdr_verify_test.rs |
Adds CAP-0071 parsing coverage and migrates imports. |
src/tests/xdr_verification_e2e_test.rs |
Migrates the test import. |
src/tests/utils.rs |
Migrates test utilities to root exports. |
src/tests/report_test.rs |
Migrates the test import. |
src/tests/repair_op_test.rs |
Migrates repair-test imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pubnet transactions files containing CAP-0071 SOROBAN_CREDENTIALS_ADDRESS_V2 credentials (first on-chain use 2026-07-09) fail to decode under stellar-xdr 26, so scan --verify reported 28 checkpoints as failed transactions files on all three public archives even though the files are valid. - stellar-xdr 26.0.0 -> 27.0.0; v27 exports types at the crate root, so rename stellar_xdr::curr:: paths to stellar_xdr:: - add a regression test parsing a tx set whose Soroban auth entry uses the AddressV2 credentials arm
jayz22
force-pushed
the
bump-stellar-xdr-27
branch
from
July 16, 2026 05:34
ad48a17 to
76e29a5
Compare
jayz22
changed the title
sisuresh
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
stellar-xdrfrom 26.0.0 to 27.0.0, renamingstellar_xdr::curr::paths tostellar_xdr::(v27 exports all types at the crate root).SOROBAN_CREDENTIALS_ADDRESS_V2credentials arm.Why
scan --verifycurrently reports 28 checkpoints (ledgers 63,401,919–63,479,423) as failedtransactionsfiles on all three pubnet archives. The files are valid: they contain CAP-0071 (protocol 27)AddressV2Soroban credentials — which stellar-xdr 26 cannot decode, so healthy archives are flagged as corrupt.With this bump, all 28 previously-failing checkpoints verify clean on
core_live_001/002/003, and a full sweep ofcore_live_001from ledger 63,400,000 to the archive tip (18,904 files) passes with zero failures.