[Security Issue] Apply secure_filename to snapshot_path for security hardening #688
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
snapshot_path
parameter.This change uses
secure_filename
fromwerkzeug.utils
to sanitize thesnapshot_path
value obtained from user input, preventing malicious path traversal or unauthorized file access.Problem
Previously, the
snapshot_path
parameter was used without validation. An attacker could exploit this by passing values like../../etc/passwd
, potentially gaining access to sensitive files on the server. This posed a serious path injection security risk.Code Change
The
secure_filename
function ensures the input is converted to a safe, valid filename, effectively blocking directory traversal attempts.Test Plan
snapshot_path=../../etc/passwd
etc_passwd
), preventing unauthorized access