-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies (fixes #13), fix bugs, add USB support #14
Open
valpackett
wants to merge
12
commits into
stm32-rs:master
Choose a base branch
from
valpackett:deps-and-usb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jyri Genral <[email protected]>
Signed-off-by: Jyri Genral <[email protected]>
Signed-off-by: Jyri Genral <[email protected]>
This was referenced Jan 10, 2022
Thank you! I will try to find some time to run examples on my keyboard. USB support is essential |
thanks for porting it to rtic@1 as well! I'm working through their examples again. |
The usage of .write() was disabling the PLL's source (!) exactly when the PLL itself was enabled, causing the PLL to never come up.
24 is not a real restriction: anything above 16 requires setting LATENCY (1 WS) for flash already. 32 is when the flash maxes out even in LATENCY mode.
Mostly based on the other STM32 HALs
Inspired by f1 hal
valpackett
force-pushed
the
deps-and-usb
branch
from
December 29, 2022 06:03
017ad89
to
af7cc9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Continues #11)
TODO:
dp.FLASH.acr
fiddling in the USB example /* RM0038 3.3.1 */startup_delay
—72
copy-pasted from F1 does just work but may be excessive?enable
into functions like other HALs do:USB::enable_unchecked()
etc. (how do they do that?)