-
Notifications
You must be signed in to change notification settings - Fork 108
https://issues.redhat.com/browse/ACM-20516 #7799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clusters/release_notes/errata.adoc
Outdated
|
||
* Delivers updates to one or more product container images. | ||
|
||
* Ensures that both the namespace and the associated `Work RoleBinding` resource get properly deleted. (https://issues.redhat.com/browse/ACM-18107[ACM-18107]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhiweiyin318 would you please let me know what you think of this summary since I condensed it from your summarization? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using RoleBinding
instead of Work RoleBinding
here.
Ensures that both the Namespace and the associated RoleBinding resource get properly deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is addressed, so I will merge.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, swopebe, zhiweiyin318 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See Jira: https://issues.redhat.com/browse/ACM-20516
See Jira where I got summary: https://issues.redhat.com/browse/ACM-18107?focusedId=27000835&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-27000835