Skip to content

https://issues.redhat.com/browse/ACM-20516 #7799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

@jc-berger jc-berger self-assigned this May 6, 2025

* Delivers updates to one or more product container images.

* Ensures that both the namespace and the associated `Work RoleBinding` resource get properly deleted. (https://issues.redhat.com/browse/ACM-18107[ACM-18107])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhiweiyin318 would you please let me know what you think of this summary since I condensed it from your summarization? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using RoleBinding instead of Work RoleBinding here.

Ensures that both the Namespace and the associated RoleBinding resource get properly deleted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is addressed, so I will merge.

@zhiweiyin318
Copy link
Contributor

/lgtm

Copy link
Contributor

@swopebe swopebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, swopebe, zhiweiyin318

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swopebe swopebe changed the title https://issues.redhat.com/browse/ACM-20516 https://issues.redhat.com/browse/ACM-20516 [not ready to merge] May 8, 2025
@swopebe swopebe merged commit 8174493 into 2.11_stage May 8, 2025
0 of 2 checks passed
@swopebe swopebe changed the title https://issues.redhat.com/browse/ACM-20516 [not ready to merge] https://issues.redhat.com/browse/ACM-20516 May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants