-
Notifications
You must be signed in to change notification settings - Fork 108
https://issues.redhat.com/browse/ACM-20515[Not ready to merge] #7800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
release_notes/errata.adoc
Outdated
|
||
* Ensures that the changes made to the `MultiClusterObservability` (MCO) operator spec that modifies the components in the advanced config retain their resource limits and requests values. (link:https://issues.redhat.com/browse/ACM-15050[ACM-15050]) | ||
|
||
* Identifies frequently updated resource types and optimizes the CPU. (link:https://issues.redhat.com/browse/ACM-17312[ACM-17312]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smcavey please review since I took this summary from your comments in the Jira, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for all releases this Jira included a code change that reduced CPU utilization by skipping some unnecessary edge building for resources that didn't have updates. For 2.14 only we added the ability to identify the frequently updated resource types for potential greater CPU reduction.
So, all releases got a CPU optimization, but 2.14 got a new metric to identify frequently updated resources for even further CPU reduction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smcavey this release note is for 2.11.7 though, so would we want to include what's been updated for 2.14 only?
I made the change, but can revert back to something more similar to the original version if we don't want to do include a release note/errata for an update for 2.14 in 2.11.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this release I'd say just made a CPU optimization. The Identifies frequently updated resource types
is only relevant for 2.14
release_notes/errata.adoc
Outdated
|
||
* Delivers updates to one or more product container images. | ||
|
||
* Ensures that the changes made to the `MultiClusterObservability` (MCO) operator spec that modifies the components in the advanced config retain their resource limits and requests values. (link:https://issues.redhat.com/browse/ACM-15050[ACM-15050]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove MCO and please spell out specification, we only use that if coded.
release_notes/errata.adoc
Outdated
|
||
* Ensures that the changes made to the `MultiClusterObservability` (MCO) operator spec that modifies the components in the advanced config retain their resource limits and requests values. (link:https://issues.redhat.com/browse/ACM-15050[ACM-15050]) | ||
|
||
* Optimizes the CPU. (link:https://issues.redhat.com/browse/ACM-17312[ACM-17312]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put more detail, which you can prob find in the bug--CPU for what component?
release_notes/errata.adoc
Outdated
|
||
* Ensures that the changes made to the `MultiClusterObservability` operator specification that modifies the components in the advanced config retain their resource limits and requests values. (link:https://issues.redhat.com/browse/ACM-15050[ACM-15050]) | ||
|
||
* Optimizes the CPU so that it reduces its workloads by up to 60%. (link:https://issues.redhat.com/browse/ACM-17312[ACM-17312]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jc-berger I commented on Slack but you prob didn't see this. This is still outstanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the component because this could be talking about many controllers or operators...we need to be more specific.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, swopebe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See Jira: https://issues.redhat.com/browse/ACM-20515