Remove transaction equality in favor of explicit hash equality checks.

.cargo/config.offline

@@ -1,5 +1,28 @@
+[target.aarch64-unknown-linux-gnu]
+linker = "aarch64-linux-gnu-gcc"
+
 [source.crates-io]
 replace-with = "vendored-sources"
 
+[source."https://github.com/zcash/librustzcash.git"]
+git = "https://github.com/zcash/librustzcash.git"
+rev = "67cb63a5a6b1f2c4cf5a061dbe80e9a71477e289"
+replace-with = "vendored-sources"
+
+[source."https://github.com/zcash/orchard.git"]
+git = "https://github.com/zcash/orchard.git"
+rev = "f4587f790d7317df85a9ee77ce693a06ed6d8d02"
+replace-with = "vendored-sources"
+
+[source."https://github.com/zcash/incrementalmerkletree.git"]
+git = "https://github.com/zcash/incrementalmerkletree.git"
+rev = "62c33e4480a71170b02b9eb7d4b0160194f414ee"
+replace-with = "vendored-sources"
+
+[source."https://github.com/nuttycom/hdwallet.git"]
+git = "https://github.com/nuttycom/hdwallet.git"
+rev = "576683b9f2865f1118c309017ff36e01f84420c9"
+replace-with = "vendored-sources"
+
 [source.vendored-sources]
 # The directory for this source is set to RUST_VENDORED_SOURCES by src/Makefile.am

.github/ISSUE_TEMPLATE/bug-report.md

@@ -36,7 +36,7 @@ Please provide a general summary of the issue you're experiencing
 Tell us what should happen
 
 ### Actual behaviour + errors
-Tell us what happens instead including any noticable error output (any messages
+Tell us what happens instead including any noticeable error output (any messages
 displayed on-screen when e.g. a crash occurred)
 
 ### The version of Zcash you were using:

.github/workflows/lints.yml

@@ -34,10 +34,6 @@ jobs:
         if: always()
         continue-on-error: true # Temporary until we get this passing
 
-      - name: Python UTF-8 encoding
-        run: ./test/lint/lint-python-utf8-encoding.sh
-        if: always()
-
       - name: Shebang
         run: ./test/lint/lint-shebang.sh
         if: always()
@@ -57,20 +53,36 @@ jobs:
         run: ./test/lint/lint-whitespace.sh
         if: always()
 
+  python:
+    name: Python
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install dependencies
+        run: sudo python3 -m pip install pyflakes
+
+      - name: Pyflakes
+        run: pyflakes qa src zcutil
+        if: always()
+
+      - name: UTF-8 encoding
+        run: ./test/lint/lint-python-utf8-encoding.sh
+        if: always()
+
   rust-clippy:
-    name: Clippy (1.54.0)
+    name: Clippy (1.59.0)
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.54.0
+          toolchain: 1.59.0
           components: clippy
           override: true
       - name: Run clippy
         uses: actions-rs/clippy-check@v1
         with:
-          name: Clippy (1.54.0)
+          name: Clippy (1.59.0)
           token: ${{ secrets.GITHUB_TOKEN }}
           args: --all-features --all-targets -- -D warnings
 
@@ -81,7 +93,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.54.0
+          toolchain: 1.59.0
           override: true
       - run: rustup component add rustfmt
       - uses: actions-rs/cargo@v1

.gitignore

@@ -3,6 +3,7 @@
 *.exe
 src/bitcoin
 src/zcashd
+src/zcashd-wallet-tool
 src/zcash-cli
 src/zcash-gtest
 src/zcash-tx

COPYING

@@ -1,6 +1,6 @@
-Copyright (c) 2016-2021 The Zcash developers
-Copyright (c) 2009-2021 The Bitcoin Core developers
-Copyright (c) 2009-2021 Bitcoin Developers
+Copyright (c) 2016-2022 The Zcash developers
+Copyright (c) 2009-2022 The Bitcoin Core developers
+Copyright (c) 2009-2022 Bitcoin Developers
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal